Fix Zeus #211
Merged
Fix Zeus #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Zeus config has been broken since integration tests for Rails engines were added. It appears that the Zeus boot step responsible for loading Combustion was passing an empty array for the modules to initialize. Outside of Zeus, the integration test customizes this array, but inside Zeus, that never happens, and there isn't a way to do that. So, considering that we only have one engine-specific integration test, I removed the customization option and hardcoded the list of modules, renaming the boot step and corresponding command to match. I then corrected the test accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Zeus config has been broken since integration tests for Rails engines were added. It appears that the Zeus boot step responsible for loading Combustion was passing an empty array for the modules to initialize. Outside of Zeus, the integration test customizes this array, but inside Zeus, that never happens, and there isn't a way to do that. So, considering that we only have one engine-specific integration test, I removed the customization option and hardcoded the list of modules, renaming the boot step and corresponding command to match. I then corrected the test accordingly.