Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Ruby2.7 support #71

Merged
merged 2 commits into from
May 18, 2020
Merged

WIP: Ruby2.7 support #71

merged 2 commits into from
May 18, 2020

Conversation

numbata
Copy link
Contributor

@numbata numbata commented Feb 10, 2020

This PR suppress some Ruby2.7 warnings.

@mcmire
Copy link
Collaborator

mcmire commented Feb 11, 2020

Hey, thanks for doing this! Did you want to leave your commits as-is or squash them? Just making sure before I merge.

@mcmire
Copy link
Collaborator

mcmire commented Feb 11, 2020

Also it looks like @aried3r got to this first so I merged in their PR — hope that's okay. I'm assuming that the other changes here have to do with upgrading to Ruby 2.7, though? Or are they to satisfy Rubocop?

@numbata
Copy link
Contributor Author

numbata commented Feb 11, 2020

Also it looks like @aried3r got to this first so I merged in their PR — hope that's okay.

Sure 👍

I'm assuming that the other changes here have to do with upgrading to Ruby 2.7, though? Or are they to satisfy Rubocop?

Yeap, Ruby 2.7 shows some warnings right now. "warning: Using the last argument as keyword parameters is deprecated" for example. So, my changes are around suppressing that deprications and warnings.

Did you want to leave your commits as-is or squash them? Just making sure before I merge.

I'll do it. Just want to fix couple of warnings before that.

@numbata numbata changed the title Ruby2.7 support WIP: Ruby2.7 support Feb 12, 2020
@mcmire mcmire self-assigned this Feb 26, 2020
@mcmire
Copy link
Collaborator

mcmire commented May 16, 2020

Hey, just checking here. Was there any more work you wanted to do on this?

@numbata
Copy link
Contributor Author

numbata commented May 16, 2020

@mcmire thank you for your "ping" :) I'll check and back with results tomorrow.

@numbata
Copy link
Contributor Author

numbata commented May 18, 2020

@mcmire So, I did fix what I can. Other warnings are coming from the "rspec-expectations" and the "attr_extras" gems.

@mcmire mcmire merged commit ce1bb2f into splitwise:master May 18, 2020
@mcmire
Copy link
Collaborator

mcmire commented May 18, 2020

Okay! Thanks so much for doing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants