Do some reorganizing #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Rename "function" classes to Main, e.g., Differ -> Differs::Main. This makes it easier to Ctrl-P for the right files (if you were looking for differ.rb you might get differs/something_else.rb). * Change inspector classes so that what they return match what they're named after. That is, previously an Inspector actually was an InspectionTree object, and now the InspectionTree lives inside the Inspector. * Remove the inspector Map, as well as the MapExtensions which are used by extension modules such as `super_diff/rspec`, `super_diff/active_record`, etc., in favor of the same registry mechanism that differs, operational sequencers, etc. use. * Pluralize extension points in the Configuration object so that you can provide more than one custom differ, operational sequencer, etc., at a time. This reorganization is in preparation for introducing new classes in the future around eliding diff output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to Ctrl-P for the right files (if you were
looking for differ.rb you might get differs/something_else.rb).
named after. That is, previously an Inspector actually was an
InspectionTree object, and now the InspectionTree lives inside the
Inspector.
by extension modules such as
super_diff/rspec,super_diff/active_record, etc., in favor of the same registrymechanism that differs, operational sequencers, etc. use.
provide more than one custom differ, operational sequencer, etc., at a
time.
This reorganization is in preparation for introducing new classes in the
future around eliding diff output.