Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
dpm_limits
, which a single line fix; but fixing this and/or running the existing testTestAccCreateUpdateOrgToken
will fail with a server side error:This error is returned when the provider attempts to update an org token with a DPM/Category limit and not setting the
authScopes
in its payload.In this PR I added
auth_scopes
to the token schema and I made it optional to keep it backward compatible;Note, when you create a token, the server defaults to setting the value to
["API", "INGEST"]
so the initial creation succeeds whether you setauthScopes
or not; but due to the TF SDK not supportingDefault
for complex types , in this caseTypeList
, I opted to setComputed
to true; this will prevent false positive plan diffs .I also added new test.
NOTE:
Do Not Merge as this depends on this PR signalfx/signalfx-go#146 , once the it's merged, I need to update this PR to pull the new version of signalfx-goupdate: signalfx-go is updated
Signed-off-by: Dani Louca dlouca@splunk.com