Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): zero line when no data found #1480

Draft
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

soleksy-splunk
Copy link
Contributor

@soleksy-splunk soleksy-splunk commented Nov 24, 2024

Issue number:
https://splunk.atlassian.net/browse/ADDON-76195

PR Type

What kind of change does this PR introduce?

  • Feature
  • Bug Fix
  • Refactoring (no functional or API changes)
  • Documentation Update
  • Maintenance (dependency updates, CI, etc.)

Summary

Zero line is displayed when no data found for all dashboard charts, except those in resource tab.

Changes

For data charts where "No data found" message is displayed there is displayed chart with zero line, simulating none of the events to appear.

User experience

Please describe the user experience before and after this change. Screenshots are welcome for additional context.

Overview before changes:

Screenshot 2024-11-24 at 22 23 02

Overview after changes:

Screenshot 2024-11-24 at 22 19 24

Data Ingestion tab before changes:

Screenshot 2024-11-24 at 22 23 34

Data Ingestion tab after changes:

Screenshot 2024-11-24 at 22 19 53

Error tab before changes:

Screenshot 2024-11-24 at 22 25 07

Error tab after changes:

Screenshot 2024-11-24 at 22 21 08

Resource consumption tab after changes remains the same:

Screenshot 2024-11-24 at 22 21 44

Checklist

If an item doesn't apply to your changes, leave it unchecked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant