Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splunk license file #173

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

zyphermonkey
Copy link
Contributor

Allow license files to be stored in custom src dir for better organization.

Retains backwards compatability by using default filter.

Example Var definition

splunk_license_file:
  - src: licenses/splunk1.lic
    dest: splunk1.lic
  - src: licenses/Splunk2.lic
    dest: Splunk2.lic

Allow license files to be stored in custom src dir for better organization.

Retains backwards compatability by using `default` filter.

Example Var definition
```yaml
splunk_license_file:
  - src: licenses/splunk1.lic
    dest: splunk1.lic
  - src: licenses/Splunk2.lic
    dest: Splunk2.lic
```
pass4SymmKey needs to match on peers and licensemaster
become: yes
notify: restart splunk
when:
- splunk_license_group=="Enterprise"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be when "'licensemaster' in group_names".

It does not seem that much thought was put in to the LM configuration. I think there should be a splunk_lm_key variable just like there is one for the idxc etc. even though this one is in the general stanza. The default value in main.yml can be splunk_lm_key: "{{ splunk_general_key }}", but it gives you the option to customize it based on the role.

If done this way, the pass4SymmKey value for the license peer, should also be changed to splunk_lm_key.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if it is a good way to only check when "'licensemaster' in group_names", because what if someone has an additional standalone server with it's own license. I think the naming licensemaster can than be misleading.

I do not agree with a new variable, as the licensing does not have an own pass4SymmKey. It uses the one under the general stanza. So changing the pass4SymmKey besides the splunk_general_key generates different configurations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants