-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes needed to support both old and new cluster configuration #217
Open
BSonPosh
wants to merge
4
commits into
splunk:master
Choose a base branch
from
BSonPosh:fix_for_cluster_mode_version
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8.1< slave/master 8.1 >= peer/manager
dtwersky
reviewed
Aug 29, 2024
become: true | ||
become_user: "{{ splunk_nix_user }}" | ||
register: idxc_peer_init_result | ||
changed_when: idxc_peer_init_result.rc == 0 | ||
failed_when: idxc_peer_init_result.rc != 0 | ||
notify: restart splunk | ||
no_log: true | ||
no_log: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change this back to true
dtwersky
reviewed
Aug 30, 2024
I don’t think I did that. Good catch
…On Fri, Aug 30, 2024 at 8:55 AM dtwersky ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In roles/splunk/tasks/configure_idxc_manager.yml
<#217 (comment)>
:
> set_fact:
- mode_value: "{% if splunk_version_release | float < 8.1 %}master{% else %}manager{% endif %}"
+ mode_value: "manager"
Have you tried using the old method but changing it from float to version?
Using float was wrong because it will fail in some cases when there are
micro releases.
—
Reply to this email directly, view it on GitHub
<#217 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAE6UWZXMZLOJJVS5MXIP33ZUBTV3AVCNFSM6AAAAABNLAEHWGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENRZHAYTSNJVGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
dtwersky
reviewed
Aug 30, 2024
|
||
- name: Setting clustering mode to slave and uri to master base on Splunk version | ||
set_fact: | ||
mode_value: "slave" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And this:
Suggested change
mode_value: "slave" | |
mode_value: "{% if splunk_version_release | version('8.1', '<') %}slave{% else %}peer{% endif %}" |
These changes (if tested and working) will combine both 8.1 and later into one task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
8.1< slave/master
8.1 >= peer/manager