Added support for splunk.secret to be passed as a variable #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mason-splunk
changed the title
mason-splunk
suggested changes
Mar 17, 2021
mason-splunk
suggested changes
Mar 22, 2021
There was a problem hiding this comment.
Almost there, but is defined in the when only checks if the variable is actually defined anywhere with a value. Since we are setting a default value with the string value "undefined" in defaults/main.yml, this will always evaluate to true with your current conditionals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to resolve issue #50
Added a new task to setup the splunk.secret file as a template if the
splunk_secret_textvariable is set. I also included an example script to generate a new secret to store in a secret vault using the Splunk UF docker image.