Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added full_url support for splunk hec #683

Merged
merged 2 commits into from
Dec 16, 2021
Merged

added full_url support for splunk hec #683

merged 2 commits into from
Dec 16, 2021

Conversation

hvaghani221
Copy link
Contributor

Fixing #665

@hvaghani221 hvaghani221 marked this pull request as ready for review December 2, 2021 12:34
@hvaghani221 hvaghani221 requested a review from rockb1017 December 2, 2021 12:34
@hvaghani221
Copy link
Contributor Author

Extending splunk/fluent-plugin-splunk-hec#198

rockb1017
rockb1017 approved these changes Dec 8, 2021
View reviewed changes
Copy link
Contributor

@rockb1017 rockb1017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. it requires updated version of plugin. So let's wait on merging it.

@rockb1017 rockb1017 merged commit 5931c00 into develop Dec 16, 2021
@rockb1017 rockb1017 deleted the fix-issue-665 branch December 16, 2021 17:30
@jbehrends jbehrends mentioned this pull request Jan 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rockb1017 rockb1017 rockb1017 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hvaghani221 @rockb1017