Ant to Maven Migration #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ant to Maven converted. Parent-Child pom structure introduced.
…dule Below are the changes: - Maven deploy plugin dependency is moved from splunk sub-module pom to parent pom. - Distribution Management is commented out for now because we are currently focusing on local deployment only.
zenmoto
reviewed
Jun 11, 2021
splunk/pom.xml
Outdated
| <artifactId>maven-surefire-plugin</artifactId> | ||
| <version>3.0.0-M5</version> | ||
| <configuration> | ||
| <skipTests>false</skipTests> |
There was a problem hiding this comment.
Could you change this value to ${skipTests} to allow skipping tests from the command-line?
There was a problem hiding this comment.
This change is implemented and code is checked-in.
| <version>1.0.0</version> | ||
| </parent> | ||
| <properties> | ||
| <!-- <jvm.arg.https.protocol>-Dhttps.protocols=TLSv1.1,TLSv1.2</jvm.arg.https.protocol> --> |
There was a problem hiding this comment.
It seems like we have some substantial work to do on the javadoc- could you add a property here to disable javadoc generation for the moment and add another bug to clean up javadoc generation?
<maven.javadoc.skip>true</maven.javadoc.skip>
There was a problem hiding this comment.
Both changes are implemented and code is checked-in.
zenmoto
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ant to Maven Migration
Below are the list of changes: