Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed test cases failures and Clean-up Javadoc generation #159

Merged
merged 5 commits into from
Jul 1, 2021

Conversation

akaila-splunk
Copy link
Contributor

@akaila-splunk akaila-splunk commented Jun 25, 2021

  • Breaking Change: Changed getMaxHotBuckets to String type to conform to Splunk platform updates
  • 'apps/appinstall' REST API endpoint was removed in Splunk version 8.1.0 so ignored it's test cases with proper comment
  • Errors and warnings are resolve in Javadoc generation

akaila-splunk and others added 4 commits June 21, 2021 21:15
- Disable test cases of 'apps/appinstall' endpoint because it is deprecated in splunk version 8.1.0
- Modified testSetters test case due to change in default value in version 8.1.0
Update:
- Errors and warnings are resolved.
- apps/appinstall REST API endpint was removed in Splunk version 8.1.0
- test cases is failing for dockerized Splunk instance because '/etc/fstab' file is not exist so changed it's value to '/etc/hosts'
Update:
- Ant build file is no longer required as we have implemented Maven
Copy link
Contributor

@fantavlik fantavlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to the summary to call out the breaking change to getMaxHotBuckets that we discussed on a previous call - this will help us compile release notes

@ashah-splunk ashah-splunk merged commit f4c99f8 into develop Jul 1, 2021
@akaila-splunk akaila-splunk deleted the DVPL-9622 branch August 10, 2021 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants