Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Methods for setting Splunk and Bearer token added. #171

Merged
merged 2 commits into from
Sep 15, 2021
Merged

Conversation

bparmar-splunk
Copy link
Contributor

Update:

  • Splunk token and bearer token set methods are added.

@fantavlik
Copy link
Contributor

Looks good, feel free to merge - I wonder as a followup if we should adjust our tests to run using a Bearer token moving forward? If that's best practice that we're recommending for customers moving forward it would probably be best to use that workflow.

@bparmar-splunk
Copy link
Contributor Author

Looks good, feel free to merge - I wonder as a followup if we should adjust our tests to run using a Bearer token moving forward? If that's best practice that we're recommending for customers moving forward it would probably be best to use that workflow.

Thanks Tim!
And yes, we would add relevant test case for bearer token in future tickets.

@bparmar-splunk bparmar-splunk merged commit 60fefb4 into develop Sep 15, 2021
@bparmar-splunk bparmar-splunk deleted the DVPL-9993 branch December 15, 2021 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants