Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md updated with Test example #177

Merged
merged 3 commits into from
Nov 25, 2021
Merged

README.md updated with Test example #177

merged 3 commits into from
Nov 25, 2021

Conversation

bparmar-splunk
Copy link
Contributor

Update:

  • Login Examples using credentials & tokens are added.
  • Example of fetching job using Search creation.

Update:
- Login Examples using creds & tokens are added.
- Job creation using search criteria example
Copy link
Contributor

@fantavlik fantavlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments about replacing Splunk token -> session token and Bearer token -> authentication token. Feel free to merge when those corrections are made.

README.md Outdated
}
```

#### Login using Splunk Token
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the correct term here is "session tokens" can we replace references to Splunk token with session token?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Splunk token is replaced everywhere with Session token.

README.md Outdated
* In **Bearer** token, user has a provision to set token expiration time. Splunk allows user to set relative/absolute time for token expiration.
* In other words, **Bearer** token is configurable whereas Splunk token cannot be configured.

#### Login using Bearer Token (RECOMMENDED)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly here I think the correct term to use according to the docs https://docs.splunk.com/Documentation/Splunk/8.2.3/Security/CreateAuthTokens is "authentication tokens". Can we replace any mention of bearer token with authentication token?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bearer is replaced with Authentication.

README.md Outdated
}
```

For more information on authentication using tokens, please visit [Splunk Docs](https://docs.splunk.com/Documentation/Splunk/8.2.3/Security/Setupauthenticationwithtokens).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you use "lastest" instead of 8.2.3 the link will be relevant even after the next release, so https://docs.splunk.com/Documentation/Splunk/latest/Security/Setupauthenticationwithtokens

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

URL updated.

* Create Job using search creation.
* Read results and print _raw fields
*/
public class SearchExample {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that this is working, nice tutorial! 🚀

**Update:**
- Splunk token is replaced **Session token**.
- Bearer is replaced with **Authentication**.
- Splunk Docs URL is pointing to latest release.
@bparmar-splunk bparmar-splunk merged commit 8ea97d7 into develop Nov 25, 2021
@bparmar-splunk bparmar-splunk deleted the DVPL-10226 branch December 15, 2021 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants