Headers modified in Socket creation. #179

bparmar-splunk · 2021-12-01T07:24:12Z

Update:

HTTP Request using format strings to insert user supplied data into the raw requests headers. So to prevent attackers to replace escape characters in request string. It is recommended to use the PrintWriter which allows us to bifurcate headers using println method instead of manually entering \r\n characters.
Host in socket is removed as it should not be exposed to external users from request headers.

Update: - String formatter with \r\n removed and modified with alternate approach. - Host param is removed.

fantavlik · 2021-12-04T04:07:34Z

splunk/src/main/java/com/splunk/Receiver.java

@@ -83,8 +83,7 @@ public Socket attach(Args args) throws IOException {
     */
    public Socket attach(String indexName, Args args) throws IOException {
        Socket socket = service.open();
-        OutputStream ostream = socket.getOutputStream();
-        Writer out = new OutputStreamWriter(ostream, "UTF-8");
+        PrintWriter writer = new PrintWriter(new OutputStreamWriter(socket.getOutputStream(), "UTF-8"));


Why is the type of writer being changed here? It's not clear from the PR summary.

PR summary updated.

fantavlik · 2021-12-04T04:08:10Z

splunk/src/main/java/com/splunk/Receiver.java

-
-        out.write(header.toString());
-        out.flush();
+        headers.add("");


Curious what this line is doing

This empty string for headers is intentionally kept for terminating header string

fantavlik

Looks good, thanks for the explanations @bparmar-splunk 🚀

Headers modified in Socket creation.

9e4a6fa

Update: - String formatter with \r\n removed and modified with alternate approach. - Host param is removed.

bparmar-splunk requested review from zenmoto and fantavlik December 1, 2021 07:24

fantavlik requested changes Dec 4, 2021

View reviewed changes

fantavlik approved these changes Dec 6, 2021

View reviewed changes

bparmar-splunk merged commit 9af4c72 into develop Dec 7, 2021

bparmar-splunk deleted the DVPL-7634 branch December 15, 2021 07:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Headers modified in Socket creation. #179

Headers modified in Socket creation. #179

bparmar-splunk commented Dec 1, 2021 •

edited

Loading

fantavlik Dec 4, 2021

bparmar-splunk Dec 6, 2021

fantavlik Dec 4, 2021

bparmar-splunk Dec 6, 2021

fantavlik left a comment

Headers modified in Socket creation. #179

Headers modified in Socket creation. #179

Conversation

bparmar-splunk commented Dec 1, 2021 • edited Loading

fantavlik Dec 4, 2021

Choose a reason for hiding this comment

bparmar-splunk Dec 6, 2021

Choose a reason for hiding this comment

fantavlik Dec 4, 2021

Choose a reason for hiding this comment

bparmar-splunk Dec 6, 2021

Choose a reason for hiding this comment

fantavlik left a comment

Choose a reason for hiding this comment

bparmar-splunk commented Dec 1, 2021 •

edited

Loading