Switch Var Header to binary format #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrannajaryan
force-pushed
the
tigran/schemaformat
branch
from
3fc9bde to
665fd18
Compare
tigrannajaryan
force-pushed
the
tigran/varheaderformat
branch
2 times, most recently
from
6a2ae94 to
2016f30
Compare
tigrannajaryan
force-pushed
the
tigran/varheaderformat
branch
7 times, most recently
from
51de77b to
8db0d07
Compare
Resolves #25 This eliminates dependency on JSON. All var header is now in custom binary format, which is fast and compact. I changed UserData to be map[string]string instead of map[string]any. This makes the format simpler and is good enough for UserData, we don't need to support arbitrary types and complicate the format of the header. I also updated STEF/gRPC implementation to correctly use the binary format for schema. It was missed in #23 Note that stefgen command continues to use JSON format, since we need a human readable format as an input to generator.
tigrannajaryan
force-pushed
the
tigran/varheaderformat
branch
from
8db0d07 to
ab9343c
Compare
|
@dmitryax PTAL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #25
This eliminates dependency on JSON. All var header is now
in custom binary format, which is fast and compact.
I changed UserData to be map[string]string instead of map[string]any.
This makes the format simpler and is good enough for UserData,
we don't need to support arbitrary types and complicate the
format of the header.
I also updated STEF/gRPC implementation to correctly use the binary
format for schema. It was missed in #23
Note that stefgen command continues to use JSON format, since we
need a human readable format as an input to generator.