-
Notifications
You must be signed in to change notification settings - Fork 267
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Removing support for multiple query value notations.
- Loading branch information
Bob Aman
committed
Jul 21, 2012
1 parent
cf04765
commit f51e290
Showing
3 changed files
with
189 additions
and
283 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
f51e290
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change breaks backwards compatibility in 2.x.x major version.
Do you have any recommendation on to upgrade libs depending on previous default "subscript" notation,
to be compatible with addressable >= 2.3.0? Is there any easy way to convert result of query_values(Array)
to a hash returned by subscript notation? i.e for "a[]=1&a[]=2"?
f51e290
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed already in issue #77.
I strongly recommend that everyone move away from the old notation if at all possible. If it's not possible, well, there's no reason you couldn't extract the old code from the commit preceding this one and run it side-by-side with the current version of Addressable via a subclass. I expect that approach will work for quite some time, though obviously it will be brittle to a degree.