Read executables from gemspec #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some gems may use a directory other than bin (for example, exe). Additionally, some gemspecs may have dependencies (Bundler 1.1's gemspec uses git), so the installed gemspec is used.
| ruby_libs = Dir.glob("#{prefix}/gems/*/lib") | ||
| Pathname.glob("#{brew_gem_prefix}/bin/*").each do |file| | ||
| Pathname.glob("#{brew_gem_prefix}/#{bindir}/*").each do |file| |
There was a problem hiding this comment.
This looks great. One suggestion as long as we're here. A Gem::Specification also has an executables field that specifies which scripts should be executable. How about instead of globbing the bindir that we do something like
gemspec = Gem::Specification::load(...)
bindir = gemspec.bindir
ruby_libs = Dir.glob("#{prefix}/gems/*/lib")
executables = gemspec.executables.map {|exe| "#{brew_gem_prefix}/#{bindir}/#{exe}" }
executables.each do |file|
# rest of the code below
endThere was a problem hiding this comment.
Done, with a slightly different implementation.
|
👍 |
|
@nicksieger is that 👍 on CR and QA? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #20.
Read executable directory and filenames from the gemspec when creating links, because some gems may use a directory other than bin (for example, exe).
Some gemspecs may have dependencies (Bundler 1.12's gemspec uses git), so the installed gemspec is used.