Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Octocat merge message for conflicts? #26

Open
chrisarcand opened this issue Jul 27, 2014 · 3 comments
Open

Octocat merge message for conflicts? #26

chrisarcand opened this issue Jul 27, 2014 · 3 comments
Labels

Comments

@chrisarcand
Copy link
Collaborator

I have not given a ton of thought into how one would accomplish this, but if anyone has time perhaps we should see about adding automated messages ( :octocat: Merged into staging.2014.07.04) for when merges happen with conflicts. Currently if you have a schema conflict or something and stage up, you won't get the convenient comment in your PR letting people know it's been staged (or restaged). I often add the comment manually now.

Perhaps a simple parsing of the commit message for a merge would be sufficient.

@jerickson
Copy link

Also, it seems like octopolo should not add the deployable label to a PR when a merge conflict prevents the deployable command from completing without errors. I'm sure the same is true for the other octopolo commands that add labels to PR's.

@anfleene anfleene added the bug label Dec 12, 2014
@anfleene
Copy link

I agree this is pretty annoying.

@chrisarcand
Copy link
Collaborator Author

A few notes for when somebody takes this:

  1. The original issue of staging comments with conflicts is still outstanding; This block's steps need to fail gracefully: https://github.com/sportngin/octopolo/blob/master/lib/octopolo/pull_request_merger.rb#L39
  2. The deployable label issue mentioned by @jerickson should be fixed (or refactored anyway) in More helpful errors / Refactor Deployable script #43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants