Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Putting in an invalid jira ticket ID makes pull-request bomb hard #36

Closed
anfleene opened this issue Sep 2, 2014 · 8 comments
Closed
Labels

Comments

@anfleene
Copy link

anfleene commented Sep 2, 2014

So basically adding an invalid jira id throws up but still creates a Pull Request. It should probably not do that. It shouldn't fail so hard, and it shouldn't make a PR in a failure situation.

@anfleene anfleene added the bug label Sep 2, 2014
@chrisarcand
Copy link
Contributor

You mean 'shouldn't make a PR in a failure situation', right?

@anfleene
Copy link
Author

anfleene commented Mar 5, 2015

yes

@chrisarcand
Copy link
Contributor

This is somewhat related to #26 as well. Basically we need to make PR's not trainwreck every time something in that block breaks. Might peek at this next week for fun.

@anfleene
Copy link
Author

anfleene commented Mar 6, 2015

agreed It leaves you a bit of a mess when things don't go as planned. accept-pull isn't much better

@astuyve
Copy link

astuyve commented Jul 15, 2016

Closing issue as fixed.

@astuyve astuyve closed this as completed Jul 15, 2016
@chrisarcand
Copy link
Contributor

Where's the commit that fixed this?

@astuyve
Copy link

astuyve commented Jul 15, 2016

referenced here: #84

@chrisarcand
Copy link
Contributor

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants