-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Putting in an invalid jira ticket ID makes pull-request bomb hard #36
Comments
You mean 'shouldn't make a PR in a failure situation', right? |
This is somewhat related to #26 as well. Basically we need to make PR's not trainwreck every time something in that block breaks. Might peek at this next week for fun. |
agreed It leaves you a bit of a mess when things don't go as planned. accept-pull isn't much better |
Closing issue as fixed. |
Where's the commit that fixed this? |
referenced here: #84 |
❤️ |
So basically adding an invalid jira id throws up but still creates a Pull Request. It should probably not do that. It shouldn't fail so hard, and it shouldn't make a PR in a failure situation.
The text was updated successfully, but these errors were encountered: