Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IS-4641-spring-cleaning-jira-bomb #84

Merged
merged 2 commits into from
May 17, 2016

Conversation

newzac
Copy link
Contributor

@newzac newzac commented May 17, 2016

Fixes Octopolo so that it doesn't bomb when Jira Story ID is invalid or if Jira's API fails.

This addresses issue #36.

Rollback Plan

If this pull request requires anything more complex (e.g., rolling back a migration), you MUST update this section. Otherwise, delete this note.

To roll back this change, revert the merge with git revert -m 1 MERGE_SHA and perform another deploy.

URLs

QA Plan

  • check out this branch and make a new branch from it
  • make a small change like adding a new file and commit it
  • run bundle exec op pull-request
    • enter an invalid Jira issue ID
    • Octopolo shouldn't fail

@newzac newzac added the bug label May 17, 2016
@zserre
Copy link

zserre commented May 17, 2016

code looks good 👍

@carlallen
Copy link

QA :shipit:

@anfleene anfleene merged commit 0b76358 into master May 17, 2016
@emmahsax emmahsax deleted the IS-4641-spring-cleaning-jira-bomb branch July 14, 2020 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants