Check PR status before marking deployable/accept-pull #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amenon
changed the title
|
We should add the ignore flag to the deployable command as well. |
|
Added the
|
|
Intuitively this could be called |
bbergstrom
approved these changes
Nov 17, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If a repository has status checks enabled, ensure that the all the checks have passed before:
deployableQA Plan
deployable
Attempt to mark a PR as deployable if it hasn't passed its status checks. This should fail.
After the status checks have passed, this should succeed and mark the PR as deployable
accept-pull
Attempt to accept a PR as deployable if it hasn't passed its status checks. This should fail.
Force accept a PR even if the status checks haven't passed
accept-pullshould succeed if the PR status checks have passed