Github team_member? method #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
amenon
suggested changes
Jul 31, 2017
There was a problem hiding this comment.
@LanceHolsten, the code in here looks good. Please add a test similar to one of the other ones in:
https://github.com/sportngin/octopolo/blob/master/spec/octopolo/github_spec.rb
|
I realize my two tests test the exact same flow, but I wrote two (one for each possible outcome) in case it's important to illustrate all possibilities. Note: Also I wouldn't be surprised if this isn't how these are meant to be tested... |
amenon
approved these changes
Aug 1, 2017
|
|
Has QA approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adding a
team_membership?method to the Github module in order to apply restrictions on certain AutoMobile commandsWhy
To restrict the use of new AutoMobile commands to certain users
Rollback Plan
git revert -m 1 MERGE_SHAand perform another deploy.URLs
QA Plan
I have tested this change in conjunction with AutoMobile's #154 using the auto_mobile_test repo with success, but I am not sure how to test this method while stand-alone.