Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix merging into deployable #120

Merged
merged 6 commits into from
Mar 26, 2018
Merged

Fix merging into deployable #120

merged 6 commits into from
Mar 26, 2018

Conversation

emmahsax
Copy link
Contributor

@emmahsax emmahsax commented Mar 22, 2018 •
edited by real-mj-song
Loading

What

What are you changing? Describe impact and scope.

Why

Why is this being changed? Provide some context that may help future developers understand the reasoning behind these changes. Quote and/or link to requirements, keeping in mind that JIRA/A-HA/etc links may not be available in the future.

Deploy Plan

Does Platform Operations need to know anything special about this deploy? Are migrations present?

Rollback Plan

  • To roll back this change, revert the merge with: git revert -m 1 MERGE_SHA and perform another deploy.

URLs

Links to bug tickets or user stories.

QA Plan

  • Hop over to Test PR 1 #118 and make sure it's in the deployable branch
  • Hop over to Test PR 2 #119 and make sure it's not in deployable branch
  • Try to merge Test PR 2 #119 to the deployable branch by running op deployable from the branch test2
  • Verify there is an error when deploying
  • Verify Test PR 2 #119 still does not have a deployable label

anfleene
anfleene previously approved these changes Mar 23, 2018
View reviewed changes
@production-status-check
Copy link

:octocat: Has QA approval

@emmahsax emmahsax merged commit 16a5395 into master Mar 26, 2018
emmahsax added a commit that referenced this pull request Mar 26, 2018
@emmahsax
Merge pull request #120 from origin/switch-order-of-deployable
2e868d9
@emmahsax emmahsax deleted the switch-order-of-deployable branch July 14, 2020 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anfleene anfleene anfleene approved these changes

Assignees
No one assigned
Labels
qa-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@emmahsax @anfleene @real-mj-song