Octopolo asks label-related questions as an array of objects #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmahsax
changed the title
mpillsbury
reviewed
Jul 17, 2018
lib/octopolo/cli.rb
Outdated
| @@ -114,21 +114,18 @@ def self.perform_in(dir) | |||
|
|
|||
| def self.ask(question, choices, skip_asking = false) | |||
| return choices.first if choices.size == 1 | |||
|
|
|||
| unless skip_asking | |||
There was a problem hiding this comment.
Why ignore this param now?
There was a problem hiding this comment.
If I'm understanding the code correctly, we never actually call this method with the skip_asking set to true, unless it's in a test. So I'm not sure if there was a point keeping it around. Seemed to just confuse me. I could put it back in, but by the time I realized we could keep it, I had already moved around the tests.
There was a problem hiding this comment.
Can we take it out of the method signature then (on line 115)? I'm sure Rubocop wouldn't like us leaving it around...
There was a problem hiding this comment.
Oh right. missed that
|
|
Has QA approval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and Why
No user-facing changes. Update how octopolo asks the user to update labels: although it will look the same to users right now, actually have asking a label-related question make a octopolo question object, and then ask each object. This creates the ability to ask the users multiple label-related questions for each PR or issue, instead of just a hard-coded single question.
Deploy Plan
Merge this PR and make a new release (minor version change). Put new release on RubyGems.
Rollback Plan
To roll back this change, revert the merge with
git revert -m 1 MERGE_SHAand perform another deploy.QA Plan
bundle install(rungem install bundlerbefore this command if necessary)bin/op pull-requestto make a test PR using this codebin/op issueto make a test issue using this code