Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pagination issue #130

Merged
merged 5 commits into from
Sep 5, 2018
Merged

Fix pagination issue #130

merged 5 commits into from
Sep 5, 2018

Conversation

emmahsax
Copy link
Contributor

@emmahsax emmahsax commented Sep 4, 2018

Issue exists where when making a PR/issue on a repo with more than 30 labels, it tries to make labels that already exist (because the label is just on a different page). So now, go through all of the pages of labels to ensure that we get all of them.

Deploy Plan

Make a new bug fix release.

Rollback Plan

If this pull request requires anything more complex (e.g., rolling back a migration), you MUST update this section. Otherwise, delete this note.

To roll back this change, revert the merge with git revert -m 1 MERGE_SHA and perform another deploy.

URLs

QA Plan

Run op pull-request on a file that has more than 30 labels. Verify that it succeeds in making a new pull request.

@emmahsax
Copy link
Contributor Author

emmahsax commented Sep 4, 2018

$ oppr
Preparing a pull request for sportngin/guardhouse/test to sportngin/guardhouse/master.
Title:
asdf
Risk Severity Label:
1) low-risk
2) medium-risk
3) high-risk
4) None
> 1
Jira story ID(s):
error:

@production-status-check
Copy link

:octocat: Has QA approval

@emmahsax emmahsax merged commit debd4f2 into master Sep 5, 2018
emmahsax added a commit that referenced this pull request Sep 5, 2018
@emmahsax emmahsax deleted the fix-bug branch July 14, 2020 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants