Fail on PR merge errors #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmahsax
previously approved these changes
Nov 9, 2018
|
|
Has QA approval
emmahsax
approved these changes
Nov 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raises errors during PR merge errors, so that chained console commands do not run.
Deploy Plan
Does Infrastructure need to know anything special about this deploy? If so, keep this section and fill it in. Otherwise, delete it.
Rollback Plan
If this pull request requires anything more complex (e.g., rolling back a migration), you MUST update this section. Otherwise, delete this note.
To roll back this change, revert the merge with
git revert -m 1 MERGE_SHAand perform another deploy.URLs
QA Plan
Provide a detailed QA plan, or other developers will retain the right to mock you mercilessly.