Make expedite's branch form more flexible

[emmahsax]

What

Make expedite's branch form more flexible. So take iss-123_describe_branch, but also accept iss_123_describe_branch as well.

Why

Because with all underscores is the form that I use, so I want to be able to use expedite with my branches.

Deploy Plan

Does Platform Operations need to know anything special about this deploy? Are migrations present?

Rollback Plan

• To roll back this change, revert the merge with: git revert -m 1 MERGE_SHA and perform another deploy.

URLs

Links to bug tickets or user stories.

QA Plan

• Checkout this branch of octopolo
• Make a branch with the form iss_123_describe_branch in another directory

  git checkout -b iss_123_describe_branch
  git pull origin iss_123_describe_branch
  git commit --allow-empty -m "Empty commit"
  git push
  

• Go back to the source branch (this branch)
• Also make a branch with the form iss-123_describe_branch in the same directory

  git checkout -b iss-123_describe_branch
  git pull origin iss-123_describe_branch
  git commit --allow-empty -m "Empty commit"
  git push
  

• Run bundle exec bin/op pull-request -x with both branches you made
• Verify two new pull requests were made with the proper titles

[emmahsax]

Capitalize the first letter of the description

[real-mj-song]

/[A-Za-z]+-\d+_.*/ and /[A-Za-z]+_\d+_.*/ for regex because we probably want them to always start with a letter.

[tsndqst]

Can this be rewritten as return if /[a-zA-Z]+[-_]\d+_.*/ =~ git.current_branch

[emmahsax]

Ah oh yes, that would probably work as well... checking for either _ or -.

[emmahsax]

Thanks @pete2786 !

[emmahsax]

#136
#137
Wooo! It works!

[production-status-check]

Has QA approval