Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where op tag-release on repo with no releases breaks #139

Merged
merged 2 commits into from
Jun 12, 2020

Conversation

emmahsax
Copy link
Contributor

@emmahsax emmahsax commented Jun 9, 2020

What

See #129 for more information. Just simply rescue that error, and then op tag-release continues how a user would expect.

Why

This will fix #129.

Deploy Plan

Does Platform Operations need to know anything special about this deploy? Are migrations present?

Rollback Plan

  • To roll back this change, revert the merge with: git revert -m 1 MERGE_SHA and perform another deploy.

URLs

Links to bug tickets or user stories.

QA Plan

@emmahsax emmahsax marked this pull request as draft June 9, 2020 21:30
@emmahsax emmahsax marked this pull request as ready for review June 12, 2020 16:40
@emmahsax
Copy link
Contributor Author

QA

$ GLI_DEBUG=true ../octopolo/bin/op tag-release
You are creating the first GitHub release for this repository.
Which version section do you want to increment?
1) Major
2) Minor
3) Patch
> 2
git add CHANGELOG.markdown
git commit -m 'Updating Changelog for 0.1.0'
[master add90fe] Updating Changelog for 0.1.0
 1 file changed, 1 insertion(+)
git tag 0.1.0
git push origin master
git push --tag

image

@production-status-check
Copy link

:octocat: Has QA approval

@production-status-check
Copy link

:octocat: Needs QA approval

Copy link

@anfleene anfleene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for this failure mode?

@production-status-check
Copy link

:octocat: Has QA approval

@emmahsax emmahsax requested a review from anfleene June 12, 2020 18:59
@emmahsax emmahsax merged commit 5421e33 into master Jun 12, 2020
@emmahsax emmahsax deleted the fix_tag_release_bug branch July 14, 2020 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attempting op tag-release on a repo with no releases breaks
2 participants