IS-12227 Upgrade octokit #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Merged into staging.2014.07.28.
sgriff44
approved these changes
Jun 12, 2020
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Enforce Hubstats to use octokit version 4.18.0 or higher.
Why
Because upcoming deprecations will make earlier versions of octokit fail: https://developer.github.com/changes/2020-02-10-deprecating-auth-through-query-param/
Deploy Plan
Run the following:
Rollback Plan
git revert -m 1 MERGE_SHAand perform another deploy.URLs
QA Plan
bin/op stage-upNow you know that the code still works even with using higher version of octokit.