Continuing adding deployable label #20
Conversation
|
@NickLaMuro check this out when you get a chance? |
| end | ||
|
|
||
| def == (obj) | ||
| return true if ((self.name == obj.name) && (self.color == obj.color)) |
There was a problem hiding this comment.
We are going to want to do some tests with this. From what we tested through the UI, it seems like only the name is the attribute that gets a uniqueness validation.
Also, is this used anywhere?
There was a problem hiding this comment.
Had my second question answered.
| # pull_number - number of the pull_request to add label to | ||
| def self.add_to_pull(pull_number, *labels) | ||
| label_names = get_names(build_label_array(labels)) | ||
| GitHub.add_labels_to_pull(config.github_repo, pull_number, label_names ) |
There was a problem hiding this comment.
Lets to a minor switch here:
built_labels = build_label_array(labels)
GitHub.add_labels_to_pull(config.github_repo, pull_number, get_names(built_labels) )There was a problem hiding this comment.
Really not a big deal I guess, so take it or leave it. Something about that looks better to me though.
|
@elliothursh FYI, I know that previously we were following the http://tomdoc.org/ spec for documentation. Try to keep that in mind when adding docs to methods and such. |
|
|
Merged into deployable.2014.06.26.
|
@elliothursh ^^ This caused a error: To reproduce, run |
|
|
|
|
1 similar comment
|
|
|
|
1 similar comment
|
|
|
Looks like it is working. Wait for the tests to pass and we can merge this in. 👍 |
To roll back this change, revert the merge with
git revert -m 1 MERGE_SHAand perform another deploy.URLs
QA Plan
Check tests to make sure they cover well and finish successfully