Label support for pull requests #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: lib/octopolo/github/label.rb spec/octopolo/github/label_spec.rb
| @@ -60,6 +60,10 @@ def title | |||
| pull_request_data.title | |||
| end | |||
|
|
|||
| # def number | |||
| @@ -122,6 +133,11 @@ def update_jira | |||
| end | |||
| private :update_jira | |||
|
|
|||
| def update_label | |||
| pull_request.add_labels(pull_request.repo_name, pull_request.number, label) unless (label == "Don't know yet") | |||
|
This looks good 👍 |
elliothursh
added a commit
that referenced
this pull request
Jul 25, 2014
Label support for pull requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollback Plan
If this pull request requires anything more complex (e.g., rolling back a migration), you MUST update this section. Otherwise, delete this note.
To roll back this change, revert the merge with
git revert -m 1 MERGE_SHAand perform another deploy.URLs
QA Plan
Run op pull-request, make sure it asks you a question about labels. then check to make sure the label got made.