Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new autocomplete_commands toggle; fixes #34 #44

Merged
merged 1 commit into from
Mar 6, 2015

Conversation

chrisarcand
Copy link
Collaborator

Added a new autocomplete_commands <boolean> toggle to GLI, released in 2.13.0 (form this PR: davetron5000/gli#211). This fixes the issue of partial commands doing bad things, such as op deploy -> op deployable.

QA:

Easiest QA is just building this branch locally, installing it in a project, and trying sync. Should not execute sync-branch but instead throw an UnknownCommand error.

@chrisarcand
Copy link
Collaborator Author


@anfleene @NickLaMuro

@anfleene
Copy link

anfleene commented Mar 6, 2015

you should use this to test that it doesn't autocomplete https://github.com/coderanger/rspec-command/blob/master/README.md

@anfleene
Copy link

anfleene commented Mar 6, 2015

code looks good I'll QA it when I get into the office

@chrisarcand
Copy link
Collaborator Author

@anfleene This is a 3rd party dependency 😉 Tests are in the project from whence it came.
https://github.com/davetron5000/gli/blob/gli-2/test/tc_command_finder.rb

But whoa, I didn't know about rspec-command, we should use that for applicable items in this project for sure.

@anfleene
Copy link

anfleene commented Mar 6, 2015

fair enough. yeah I just ran into it this morning looks awesome

@anfleene
Copy link

anfleene commented Mar 6, 2015

QA passes 🐑 🇮🇹

@anfleene
Copy link

anfleene commented Mar 6, 2015

@chrisarcand Have you released op before?

@chrisarcand
Copy link
Collaborator Author

@anfleene Nein. I need rubygems access and additional info if there's anything special other than just being a gem.

@chrisarcand chrisarcand merged commit e60d13e into master Mar 6, 2015
@emmahsax emmahsax deleted the autocomplete-toggle branch July 14, 2020 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants