Command Errors Should Not Be Rescued #47
Merged
+19
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 25, 2015 11:19
|
This may need to be resolved so things don't break. |
|
| subject.should_receive(:say).with(command) | ||
| Open3.should_receive(:capture3).with(command).and_raise(exception_message) | ||
| subject.should_receive(:say).with("Unable to perform '#{command}': #{exception_message}") | ||
| subject.perform(command).should be_nil | ||
| expect do |
There was a problem hiding this comment.
also using the return value of a block means using {} instead of do-end according to our style guide.
There was a problem hiding this comment.
It was past the 120 character mark so i split it up. Which style issue is worse?
There was a problem hiding this comment.
I'll switch to curly and do a line continuation.
|
👍 |
bbergstrom
added a commit
that referenced
this pull request
Mar 25, 2015
Command Errors Should Not Be Rescued
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A command error should halt further actions, bubble up and return a non-zero from octopolo. If something goes wrong with a command, we likely don't want to continue actions in an unknown state. Also, for using octopolo in scripting it is useful to have a non-zero return code when something went wrong.