Inspect error to get message + class name #67
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Merge it? Does it need to be republished after? |
|
yeah. I can give you publish access tomorrow |
rib3
added a commit
that referenced
this pull request
Oct 5, 2015
Inspect error to get message + class name
| @@ -53,7 +53,7 @@ def perform | |||
| when GitHub::PullRequest::CommentFailed | |||
| cli.say "Unable to write comment. Please navigate to #{pull_request.url} and add the comment, '#{comment_body}'" | |||
| else | |||
| cli.say "An unknown error occurred: #{e.class.to_s}" | |||
| cli.say "An unknown error occurred: #{e.inspect}" | |||
There was a problem hiding this comment.
Would it be useful to output e.backtrace too?
There was a problem hiding this comment.
Yes, IMO it should, but that's a greater argument about how user vs developer friendly the tool is.
There was a problem hiding this comment.
Also, maybe there should just be individual rescue statements for each handled error type, and then allow anything else to "break through" and produce a "natural" stack trace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
.inspectto log the message in addition to the class name.Currently: