Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct the rails versions in the travis build matrix #170

Merged
merged 1 commit into from
Feb 4, 2021
Merged

Correct the rails versions in the travis build matrix #170

merged 1 commit into from
Feb 4, 2021

Conversation

rmm5t
Copy link
Contributor

@rmm5t rmm5t commented Jan 30, 2021 •
edited
Loading

"~> 5.1" and "~> 5.2" would resolve to the same version, and "~> 6.0" resolves to 6.1.x

References #169

@rmm5t
Correct the rails versions in the travis build matrix
fb912d3 
"~> 5.1" and "~> 5.2" would resolve to the same version.
@rmm5t rmm5t force-pushed the 169-correct-travis-build-matrix branch from cfe62f0 to fb912d3 Compare January 30, 2021 01:37
This was referenced Jan 30, 2021
Merged
Merged
@rmm5t
Copy link
Contributor Author

rmm5t commented Feb 4, 2021

@pbyrne Thanks for the review. @anfleene Do you need anything adjusted before a merge?

@anfleene anfleene merged commit 80700f5 into sportngin:master Feb 4, 2021
@anfleene
Copy link
Contributor

anfleene commented Feb 4, 2021

Thanks!

@rmm5t rmm5t deleted the 169-correct-travis-build-matrix branch February 4, 2021 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbyrne pbyrne pbyrne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rmm5t @anfleene @pbyrne