Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skim Through Download Directory Subfolders for Skippable Song #2212

Closed
GGussi opened this issue Oct 14, 2024 · 4 comments · Fixed by #2214
Closed

Skim Through Download Directory Subfolders for Skippable Song #2212

GGussi opened this issue Oct 14, 2024 · 4 comments · Fixed by #2214
Assignees
@himanshumahajan138
Labels
Feature Request Feature Request

Comments

@GGussi
Copy link

GGussi commented Oct 14, 2024

Requested Feature

I'd like it if there was some way to download songs and make sure there are no duplicates in the download directories subfolders, not just the main directory. So, skip even if in subfolder.
I don't know how else to ask this because I use Spowlo which uses spotDL, and you can create subfolders automatically with the download. Having it skim through the WHOLE directory would be useful.

Possible implementation

No response
@GGussi GGussi added the Feature Request Feature Request label Oct 14, 2024
@himanshumahajan138
Copy link
Member

Assign this to me i can Workaround to fix this

himanshumahajan138 pushed a commit to himanshumahajan138/spotify-downloader that referenced this issue Oct 16, 2024
Fixes: spotDL#2212 ; Feature: Skip Duplicate Song from Sub-Folders ; …
05cb79c 
…Fixed
@himanshumahajan138 himanshumahajan138 mentioned this issue Oct 16, 2024
Merged
8 tasks
@himanshumahajan138
Copy link
Member

@GGussi @xnetcat Could you please merge my PR if its Accepted or Review if any changes are Required

@xnetcat
Copy link
Member

xnetcat commented Oct 18, 2024

@GGussi @xnetcat Could you please merge my PR if its Accepted or Review if any changes are Required

Tomorrow 100%

@himanshumahajan138
Copy link
Member

I think its tomorrow 😅

To Be Honest I need this PR to be Merged coz of Hacktoberfest so if it's possible to do then please merge this PR asap...

xnetcat pushed a commit that referenced this issue Oct 21, 2024
@himanshumahajan138
Fixes: #2212 ; Feature: Skip Duplicate Song from Sub-Folders ; Fixed (#…
e9ece49 
…2214)

Co-authored-by: Mill GithHub Actions <mill-ci@localhost>
xnetcat added a commit that referenced this issue Oct 21, 2024
@xnetcat
Revert "Fixes: #2212 ; Feature: Skip Duplicate Song from Sub-Folders …
2f5b8a7 
…; Fixed …"

This reverts commit e9ece49.
xnetcat pushed a commit that referenced this issue Oct 21, 2024
@himanshumahajan138 @xnetcat
Fixes: #2212 ; Feature: Skip Duplicate Song from Sub-Folders ; Fixed (#…
602fe87 
…2214)

Co-authored-by: Mill GithHub Actions <mill-ci@localhost>
@xnetcat xnetcat mentioned this issue Nov 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@himanshumahajan138 himanshumahajan138

Labels
Feature Request Feature Request
Projects
None yet
Milestone
No milestone
3 participants
@xnetcat @himanshumahajan138 @GGussi