-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generated playlist files do not work with the following media players: VLC, MPC-HC, PotPlayer, SMPlayer, Foobar, etc.. #2251
Comments
@PranjalSurana Can you please advise as the author of #2215? |
@Silverarmor I apologize for the inconvenience. I got the issue here, that song path would not get considered if it were in same line, as all the contents in the line would get considered as the path. |
@PranjalSurana seems like line1 is used for attributes and line 2 is used for the path. |
@PranjalSurana any update here? |
@Silverarmor When I tried modifying the default path in config for m3u, anything after the new line character was not getting considered. Debugged it and I think create_path_object method is the one that is causing it. Was trying another way to try fix this. |
@PranjalSurana Can you review #2258 |
# Title Fix m3u file creation, with correct metadata generation ## Description ## Related Issue <!--- This project only accepts pull requests related to open issues --> <!--- If suggesting a new feature or change, please discuss it in an issue first --> <!--- If fixing a bug, there should be an issue describing it with steps to reproduce --> <!--- Please link to the issue here: --> #2251 #2246 ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> ## How Has This Been Tested? <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> Update m3u_test file. Ran pylint, black and mypy and edited as required. ## Types of Changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Breaking change (fix or feature that would cause existing functionality to change) ## Checklist Go over all the following points, and put an `x` in all the boxes that apply. - [xx] My code follows the code style of this project - [x] My change requires a change to the documentation - [ x] I have updated the documentation accordingly - [ duhh] I have read the [CONTRIBUTING](/docs/CONTRIBUTING.md) document - [ also duhh] I have read the [CORE VALUES](/docs/CORE_VALUES.md) document - [ yes] I have added tests to cover my changes - [ n/a] All new and existing tests passed
Should be resolved in v4.2.11. Please test and let us know. |
System OS
Windows
Python Version
3.13 (CPython)
Install Source
pip / PyPi
Install version / commit hash
4.2.10
Expected Behavior vs Actual Behavior
Just installed 4.2.10.
The playlist files just do not open with any programs.
It has the [time in seconds] and the [title] attributes, but it is missing the path [filename] which is supposed to be on the next line & #EXTM3U tag on the 1st line?
Currently the playlist files generated by 4.2.10 are as below:
Example code from https://docs.fileformat.com/audio/m3u/
adapted:
When I manually formatted the playlist files acc to example above, ie. adding the filenames in the next line following the attributes, & the #EXTM3U tag on line 1, it started working as it was supposed to.
The playlist files of version 4.2.8 and prior contain only filenames in each line and work as intended, but without any attributes.
Steps to reproduce - Ensure to include actual links!
Traceback
Other details
No response
The text was updated successfully, but these errors were encountered: