Fix For #1018. Download error coz of Copyright issue

[dheerain]

The Below Fix is for the Copyright songs download issue.
#1018
Upon investigation I found out that out of the full playlist there are only a few songs that got downloaded. and rest failed . The issue seems to be with the Copyright items. Few links can not be downloaded directly. Updated the code to get first 10 best match links from youtube and start parsing till one runs, Upon doing this the success rate increased to around 90%.

[ghost]

Sorry for the delay. My lap was under repair. I'll review this by evening.

[phcreery]

seems like a good fix to me

[Kavan72]

@phcreery have you check, he is importing ProgressRootProcess from spotdl.download.progressHandlers but on this file i cant find this class

[phcreery]

@Kavan72, you are correct, this merge was from an outdated commit of spotdl. (Before asyncio).

The main changes I reviewed are in the function search_and_get_best_match() of spotdl/search/provider.py (463-495)

and also download_song() shown below

    # download Audio from YouTube
    if progressTracker:
        youtubeHandler = YouTube(
            url=songObj.get_youtube_link(),
            on_progress_callback=progressTracker.pytube_progress_hook
        )
    else:
        youtubeHandler = YouTube(songObj.get_youtube_link())

   # download Audio from YouTube
    YouTubeLinks = songObj.get_youtube_link(),
    for link in YouTubeLinks[0]:
        if displayManager:
            youtubeHandler = YouTube(
                url                  = link,
                on_progress_callback = displayManager.pytube_progress_hook
            )
        else:
            youtubeHandler = YouTube(link)

I apologize, I should have been more explicit. I do not think the merge is ready. I think the fix is a good idea though. @dheerain could you apply this to the latest commit of spotDL and create a new pull request?

[dheerain]

equest?

Thank you for pointing that out. I will work on that and raise a new Pull Request

[Silverarmor]

This PR has been reverted in #1053, since it removed asyncio.

[phcreery]

@dheerain could you please recreate this improvement on an up-to-date fork of the dev branch?