Improved Temp File Handling

[phcreery]

This aligns with #1076 and is mentioned in #1103
This should resolve: #1104 & #1103

Summary:

• Continuation of transition from os to pathlib for file handling done by @aklajnert
  • Improved saveFile handling #1076
• Removes any filetype from the ./Temp directory after noticing .webm files were being leftover
  • Potentially resulted from Fix #995 #1065 where it was improved to automatically selected the highest quality option (which possibly isn't always .mp4)
  • Mentioned in Error: download of a spotify playlist stops after a while #1103
• Uses escape characters (\) to avoid unintentional variable declarations in FFmpeg only in non-windows systems
  • Resolves Error: download of a spotify playlist stops after a while #1103 and Song Names with dollar signs ($) in them will cause spotDL to hang. #1104
  • $ (dollar signs) causes code to hang.
  • Note: The temp file will be missing the $ but that is an issue with pytube and it does not affect the final mp3 file name

Resources

Windows Special Chars: https://ss64.com/nt/syntax-esc.html
Linux Special Chars: https://tldp.org/LDP/Bash-Beginners-Guide/html/sect_03_03.html#:~:text=Escape%20characters%20are%20used%20to,with%20the%20exception%20of%20newline.

[aklajnert]

Good job in general, thanks for working on it.

[phcreery]

Good job in general, thanks for working on it.

Sure thing

[Silverarmor]

Should this possibly go into a new branch hotfix or similar? We would want to push this kind of change to PyPi ASAP. Not right now, but a possible scenario is that dev has some changes not yet ready for merging (in a future scenario).

Possibly we should have a hotfix branch where we push this type of bugfix to? - Or maybe it can go straight to master?

[ghost]

Hotfix branch is better. Pushing hotfixes to master can make a mess.

One the hotfix is published, we can take time to rework the code (if required) and then push the changes to Dev and eventually master.

[Silverarmor]

Also want to say a massive thank you for your hard work, especially having a well structured PR message that explains everything!

[Silverarmor]

Hotfix branch is better. Pushing hotfixes to master can make a mess.

One the hotfix is published, we can take time to rework the code (if required) and then push the changes to Dev and eventually master.

That would defeat the purpose of a hotfix branch.
The purpose is to bypass the dev branch, since the dev branch could have other unrelated changes. E.g, switching to rich could be on the dev branch, and not yet ready to go to master.

A PR like this ("urgent" bug fix), should go into hotfix (where version no is changed and code is tested), before being pushed to master as a patch (e.g. v3.2.2)

(PR --> `hotfix` --> `master`)

[aklajnert]

I guess in this case we need to create the hotfix branch from master first.

[ghost]

That would defeat the purpose of a hotfix branch.
The purpose is to bypass the dev branch, since the dev branch could have other unrelated changes. E.g, switching to rich could be on the dev branch, and not yet ready to go to master.

A PR like this ("urgent" bug fix), should go into hotfix (where version no is changed and code is tested), before being pushed to master as a patch (e.g. v3.2.2)

(PR --> `hotfix` --> `master`)

Exactly what was meant:
- PR --> hotfix --> master
- later, reworked hotfix code (if rework is required) --> dev --> master

Yes, we need to create a hotfix branch from master

[Silverarmor]

Wait that wont work @MikhailZex @aklajnert - This PR's branch was made off dev, so it would add the new CI checks & any other changes that were on dev.

How do we fix this? We want the branch not to have the changes from dev

[aklajnert]

I think this branch should be rebased with master first.

[ghost]

or simpler, copy your changes to a separate folder, fork master, copy back the changes int0 master-fork, force push that to phcreery:save_file_handling_pt2, not elegant, probably riddled with problems but it works & is considerably easier than a rebase.

[phcreery]

I am not sure a hotfix branch is even necessary. If you can test and review a PR directly, what is the need for testing and reviewing the branch if it is just going to be merged immediately?

Let me know if yall think otherwise.

[phcreery]

Wait that wont work @MikhailZex @aklajnert - This PR's branch was made off dev, so it would add the new CI checks & any other changes that were on dev.

How do we fix this? We want the branch not to have the changes from dev

I could remake the PR starting from master/hotfix ...

[aklajnert]

Did you try rebasing with master? That could do the trick.

[phcreery]

On hotfix now with corrected commits. I cloned the branch to a *_temp one. Did a git reset --hard upstream/hotfix then git push origin save_file_handling_pt2 --force on this one, then cherry-picked my commits from the clone onto this one.

[Silverarmor]

I am not sure a hotfix branch is even necessary. If you can test and review a PR directly, what is the need for testing and reviewing the branch if it is just going to be merged immediately?

Let me know if yall think otherwise.

on the hotfix branch is where we'd need to bump the version number for PyPi.