Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix custom youtube url parsing #1411

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Fix custom youtube url parsing #1411

merged 1 commit into from
Nov 9, 2021

Conversation

s1as3r
Copy link
Contributor

@s1as3r s1as3r commented Nov 9, 2021 •
edited
Loading

Fix Custom YT URL Parsing

Description

When downloading using a custom url, i.e spotdl "yt-url|spotify-url", spotDL didn't match youtube urls of type https://youtu.be/S19UcWdOA-I.

How Has This Been Tested?

pytest (python 3.9)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have read the CORE VALUES document
  • I have added tests to cover my changes
  • All new and existing tests passed

@s1as3r s1as3r requested a review from xnetcat November 9, 2021 10:13
@xnetcat xnetcat merged commit 40f6f7a into spotDL:dev Nov 9, 2021
@s1as3r s1as3r deleted the yt-fix branch November 9, 2021 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xnetcat xnetcat xnetcat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s1as3r @xnetcat