Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1433
Description
Since
spotdl
usesos.chdir
to change the download location, providinga relative path as an argument to
--ffmpeg
causes it to look for ffmpegin the incorrect location, i.e
arguments.ffmpeg
realtive to the directory wechange to.
The fix is simple, use absolute path to ffmpeg before we change the working directory.
Related Issue
#1433
How Has This Been Tested?
pytest (python 3.9)
Types of Changes
Checklist