Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile #1509

Merged
merged 3 commits into from
May 11, 2022
Merged

Update Dockerfile #1509

merged 3 commits into from
May 11, 2022

Conversation

zekroTJA
Copy link
Contributor

@zekroTJA zekroTJA commented Apr 22, 2022

Update Dockerfile

Description

I've added git as install dependency to the install list to fix the issue described in #1508. Also, I've set the default working directory /music as volume so that, if not changed or mounted specifically, downloaded content still persists after removal of the container.

Related Issue

#1508

Motivation and Context

First, it solves the issue described in #1508 and makes the image buildable. Also, it provides a simple fix for an issue, I ran into, which lead to loss of all my downloaded content because I mounted the wrong directory. By automatically creating a volume on the default download directory, this can be prevented as long as the user does not alter the output directory.

How Has This Been Tested?

I've cloned my fork with the changes and built the image which I've then used to download my Spotify library.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have read the CORE VALUES document
  • I have added tests to cover my changes
  • All new and existing tests passed

@xnetcat
Copy link
Member

xnetcat commented Apr 22, 2022

Looks good, can you also open PR for v4 if you want.

@xnetcat
Copy link
Member

xnetcat commented Apr 22, 2022

Also change base branch from master to dev

@xnetcat xnetcat changed the base branch from master to dev May 11, 2022 13:28
@xnetcat xnetcat merged commit d1ea2d7 into spotDL:dev May 11, 2022
lukaszb pushed a commit to lukaszb/spotify-downloader that referenced this pull request May 29, 2022
* add git to package install list

* make `/music` a volume

Co-authored-by: Jakub Kot <42355410+xnetcat@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants