Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FFmpeg fixes #776

Merged
merged 3 commits into from
Jul 1, 2020
Merged

FFmpeg fixes #776

merged 3 commits into from
Jul 1, 2020

Conversation

ritiek
Copy link
Member

@ritiek ritiek commented Jul 1, 2020

As discussed in #769.

ritiek added 3 commits July 1, 2020 19:40
@ritiek
Remove duplicate opus entries
ef5cbe1 
As mentioned in #769.
@ritiek
Let FFmpeg automatically identify sample rate
453d08c 
FFmpeg implicitly outputs media at the desired sample rate. So, there
is no need to explicitly specify a sample rate. This also eliminates
the possibility where the original sample rate may differ drastically
from the output sample rate.

Also refer to #769.
@ritiek
Fix tests
3eeaa45
@ritiek ritiek merged commit 1dfce01 into master Jul 1, 2020
@ritiek ritiek deleted the ffmpeg-fixes branch July 1, 2020 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ritiek