Address some of the dependency analysis work against repo to reduce defined dependencies not directly used #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maven is using wrong one, the legacy oracle one. It was long changed to jakarta under javax namespace, The original is missing meta data and not suggested to be used. I did raise a ticket with maven on this some time ago but it got no where, so since called out as not defined, I'll define the right one and exclude the other. In the end its the same but at least supported variation even though javax namespace is obsolete.
…ill just use bom now Spotbugs itself went dormant for a long time and now there are only 3 active members that includes myself. So while controlling asm is less important, it is still very important as groovy overrides asm and so does a number of other items in general and at any given time we may not release spotbugs in timely fashion as the plugins are released far faster. This will get it off the issue with analyzer though.
We do not use log4j2 as used by spotbugs, instead we use slf4j which aligns also with maven usage of the same. Further we do not use commons logging, we use jcl-over-slf4j which is a better solution until commons-logging team can convince slf4j to give up jcl over slf4j as they have already gotten spring-jcl on board. When that eventually occurs, jcl-over-slf4j can be removed, otherwise it must stay. Simple is also therefore needed so it actually logs from those tools or it simply will not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.