Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused but declared dependencies #947

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

elharo
Copy link

@elharo elharo commented Nov 30, 2024

No description provided.

@elharo elharo marked this pull request as ready for review December 1, 2024 20:06
@hazendaz
Copy link
Member

hazendaz commented Dec 1, 2024

I'll end up doing this a different way, these are actually used by maven. I don't like polluting the m2 because whomever 10-15 years ago didn't feel a need to maintain properly and doxia 2 skipped an opportunity to get coherent at the time. I see this in the maven threads constantly where releases happen but dependabot is skipped as considered unrelated. I'd be more than happen to send PRs to the older projects but if this gets working on doxia 2 that won't matter and I'm sure no one cares to release those now. These will go away once on modern stack though. I've moved them to dependency management so they don't show up during analysis and have commented why they are being overwritten. Our CI system at work pretty much sucks and this matters significantly so I end up going overboard on all projects to work around deficiencies in other components.

@elharo
Copy link
Author

elharo commented Dec 1, 2024

I don't see why these are needed. What is pulling in lang2 for instance? I'd be surprised if Maven is using that.

If you're just trying to set versions, then these should be moved to dependencyManagement, not dependencies.

@hazendaz
Copy link
Member

hazendaz commented Dec 1, 2024

I don't see why these are needed. What is pulling in lang2 for instance? I'd be surprised if Maven is using that.

If you're just trying to set versions, then these should be moved to dependencyManagement, not dependencies.

velocity 1.7 that is in doxia site renderer 1.11.1. If that had been updated to the newer velocity some years ago the issue would be gone. Its not in the newer doxia. Since that still will pull to my m2 catch and I have other projects that use newer velocity I try to keep it clean as we know that cache to skyrocket fast. I'm sure just going back to the original velocity and patching would be rather trivial. lang2 to lang3 I've never found to be difficult at all. But I don't think it would get released and I don't want to take on a fork ;) I will add the info on what is pulling it to the comments so its clear. I likely did that on a commit no one will ever find years ago.

@hazendaz
Copy link
Member

hazendaz commented Dec 1, 2024

do keep this open for now. I'm reviewing all this stuff you have brought up and working many things. I extremely appreciate your help and knowledge as it goes well beyond just this single project which will pay spades later ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants