Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.1.0-RC2 to eclipse update site #14

Closed
wants to merge 1 commit into from

Conversation

KengoTODA
Copy link
Member

This PR updates eclipse-candidate update site, and adds eclipse update site.
Both of them will host 3.1.0-RC2 version.

3.1.0-RC2 is not stable version yet, but we need to push update site to stable channel or we cannot finish making Eclipse marketplace page ready.

@iloveeclipse Please review this change. I found that artifacts.xml contains local path like file:/home/ubuntu/spotbugs/, is it OK? Previously I've confirmed that eclipse-candidate update site works well, though.

@KengoTODA KengoTODA self-assigned this May 16, 2017
@KengoTODA KengoTODA requested a review from iloveeclipse May 16, 2017 15:17
@KengoTODA KengoTODA changed the title release 3.1.0-RC2 eclipse update site Release 3.1.0-RC2 to eclipse update site May 16, 2017
@iloveeclipse
Copy link
Member

I'm sorry, I thought it is the source code repo, I see now this is the site itself.

@iloveeclipse
Copy link
Member

Feature description still mentions FindBugs: "This feature is a wrapper for the FindBugs plugin for installation via the Eclipse Update Manager."

Copy link
Member

@iloveeclipse iloveeclipse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The generated jar files AND versions inside them have wrong version: 3.1.02.20170516. Note the wrong "02" version (it should be 3.1.0, not 3.1.02).

Also site.xml has this issue, but NOT the artifacts/content files, which have 3.1.2.

@KengoTODA
Copy link
Member Author

Thanks, I've proposed spotbugs/spotbugs#173 to fix this problem.

@KengoTODA KengoTODA closed this May 17, 2017
@KengoTODA KengoTODA deleted the release-3.1.0-rc2 branch May 17, 2017 01:59
@KengoTODA
Copy link
Member Author

It is better to regenerate update site, because this version is used even in plugin jar file. I will create another PR after we release RC3 or 3.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants