Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractBugReporter emits wrong non-sensical debug output during filtering #184

Open
sewe opened this issue May 29, 2017 · 0 comments
Open
Labels

Comments

@sewe
Copy link

sewe commented May 29, 2017

Either the filtering logic or the debug output in AbstractBugReporter is wrong. With -Dabreporter.debug=true set, I just got the following non-sensical output:

AbstractBugReporter: Filtering due to rankThreshold 20 > 20
AbstractBugReporter: Filtering due to rankThreshold 19 > 20

Neither inequality is true.

@KengoTODA KengoTODA added the bug label Sep 26, 2017
Alex-Vol-Amz added a commit to Alex-Vol-Amz/spotbugs that referenced this issue Jan 2, 2023
The logic conditionals were entangled in an invalid way that produced
nonsense debug log messages. Simplified the logic and reduced the logic
branches to make the operation direct and thus fix the problem.
Alex-Vol-Amz added a commit to Alex-Vol-Amz/spotbugs that referenced this issue Jan 2, 2023
The logic conditionals were entangled in an invalid way that produced
nonsense debug log messages. Simplified the logic and reduced the logic
branches to make the operation direct and thus fix the problem.
hazendaz pushed a commit that referenced this issue Jan 5, 2023
* Fix Issue #184

The logic conditionals were entangled in an invalid way that produced
nonsense debug log messages. Simplified the logic and reduced the logic
branches to make the operation direct and thus fix the problem.

* Added unit test to prove correct behavior of priority and rank

This unit test serves as proof that the reportBug function is operating
as expected with respect to reporting based on priority and rank
threshold values.

As a bonus this test also verifies that the relaxed mode will override
any rank or priority and always report bugs found.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants