Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update visitorId context key to visitor_id #145

Merged
merged 1 commit into from
May 10, 2024
Merged

fix: update visitorId context key to visitor_id #145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Confidence/src/main/java/com/spotify/confidence/Confidence.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ class Confidence internal constructor(
}
}

internal const val VISITOR_ID_CONTEXT_KEY = "visitorId"
internal const val VISITOR_ID_CONTEXT_KEY = "visitor_id"

object ConfidenceFactory {
fun create(
Expand Down
2 changes: 1 addition & 1 deletion Confidence/src/test/java/com/spotify/confidence/ConfidenceRemoteClientTests.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,7 @@ internal class ConfidenceRemoteClientTests {
" \"clientSecret\": \"secret1\",\n" +
" \"resolveToken\": \"token1\",\n" +
" \"sdk\": {\n" +
" \"id\": \"SDK_ID_KOTLIN_PROVIDER_TEST\",\n" +
" \"id\": \"SDK_ID_KOTLIN_CONFIDENCE_TEST\",\n" +
" \"version\": \"\"\n" +
" }\n" +
"}"
Expand Down
2 changes: 1 addition & 1 deletion Provider/src/test/java/com/spotify/confidence/openfeature/InMemorySharedPreferences.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ package com.spotify.confidence.openfeature
import android.content.SharedPreferences

internal const val SHARED_PREFS_NAME = "confidence-visitor"
internal const val VISITOR_ID_SHARED_PREFS_KEY = "visitorId"
internal const val VISITOR_ID_SHARED_PREFS_KEY = "visitor_id"

internal class InMemorySharedPreferences : SharedPreferences {
private var visitorId: String = ""
Expand Down
Loading