Add probot/stale config to close stale issues #400
Conversation
davidxia
force-pushed
the
dxia/stale-config
branch
2 times, most recently
from
a454cb4 to
31e9d8c
Compare
caipre
changed the title
.github/stale.yml
Outdated
| staleLabel: wontfix | ||
| markComment: > | ||
| This issue has been automatically marked as stale because it has not had | ||
| recent activity. It will be closed if no further activity occurs. Thank you |
There was a problem hiding this comment.
Perhaps "any activity in the past 60 days".
There was a problem hiding this comment.
I left this without a number to prevent it falling out of sync with the param above.
There was a problem hiding this comment.
Could you elaborate a bit on the goal of using a plugin like this? I worry that closing genuine issues from people where the issue has had no activity - because this repo is more or less deprecated - could be perceived as aggressive or hostile.
I can see how this is useful in a repo with 1000s of issues like github.com/kubernetes/kubernetes, but this repo has just three dozen issues.
.github/stale.yml
Outdated
| exemptLabels: | ||
| - pinned | ||
| - security | ||
| staleLabel: wontfix |
There was a problem hiding this comment.
Seems like a fitting label. Open to suggestions though.
There was a problem hiding this comment.
how about "closed-stale" or something similar?
.github/stale.yml
Outdated
| staleLabel: wontfix | ||
| markComment: > | ||
| This issue has been automatically marked as stale because it has not had | ||
| recent activity. It will be closed if no further activity occurs. Thank you |
There was a problem hiding this comment.
is there a way for an issue reporter to specify that their issue should not be closed because it is not "stale"? Are they expected to just keep commenting? I see that there are exemptLabels but I am not sure if an issue reporter can set labels at all.
There was a problem hiding this comment.
Yes, exemptLabels does this. The idea is that only maintainers can exempt issues or PRs. If we let users do that, it defeats the purpose.
There was a problem hiding this comment.
@mattnworb Good points. I think https://github.com/probot/stale#is-closing-stale-issues-really-a-good-idea sums up my rationale nicely. This is just a test to see how it's received. I often open issues and PRs on other repos that go stale. When I get a stale-we-are-closing notification, I'm not offended. Especially if the TTL is something long like 60 days.
Also testing on this repo first since it's not an important one.
.github/stale.yml
Outdated
| staleLabel: wontfix | ||
| markComment: > | ||
| This issue has been automatically marked as stale because it has not had | ||
| recent activity. It will be closed if no further activity occurs. Thank you |
There was a problem hiding this comment.
I left this without a number to prevent it falling out of sync with the param above.
.github/stale.yml
Outdated
| exemptLabels: | ||
| - pinned | ||
| - security | ||
| staleLabel: wontfix |
There was a problem hiding this comment.
Seems like a fitting label. Open to suggestions though.
.github/stale.yml
Outdated
| staleLabel: wontfix | ||
| markComment: > | ||
| This issue has been automatically marked as stale because it has not had | ||
| recent activity. It will be closed if no further activity occurs. Thank you |
There was a problem hiding this comment.
Yes, exemptLabels does this. The idea is that only maintainers can exempt issues or PRs. If we let users do that, it defeats the purpose.
.github/stale.yml
Outdated
| exemptLabels: | ||
| - pinned | ||
| - security | ||
| staleLabel: wontfix |
There was a problem hiding this comment.
how about "closed-stale" or something similar?
davidxia
force-pushed
the
dxia/stale-config
branch
from
31e9d8c to
2666eac
Compare
davidxia
changed the title
davidxia
force-pushed
the
dxia/stale-config
branch
from
2666eac to
cf5ab61
Compare
|
Updated staleLabel to |
Let's try out this bot. See https://probot.github.io/apps/stale/ and https://github.com/probot/stale. Also used by spotify/luigi and spotify/pythonflow.
davidxia
force-pushed
the
dxia/stale-config
branch
from
cf5ab61 to
ad06096
Compare
It has been working pretty well for spotify/docker-maven-plugin since we added it here spotify/docker-maven-plugin#400.
It has been working pretty well for spotify/docker-maven-plugin since we added it here spotify/docker-maven-plugin#400.
Let's try out this bot.
See https://probot.github.io/apps/stale/ and https://github.com/probot/stale.
Also used by spotify/luigi and spotify/pythonflow.