Skip to content
This repository has been archived by the owner on Mar 31, 2022. It is now read-only.

gh-179 fix password decryption on docker pull #199

Merged
merged 1 commit into from
Aug 8, 2018

Conversation

andreysaksonov
Copy link
Contributor

@andreysaksonov andreysaksonov commented Jul 25, 2018

Fix for gh-179

@davidxia
Copy link
Contributor

davidxia commented Aug 5, 2018

@andreysaksonov thanks for the PR. Can @NargiT @eyeqinglan @Tzrlk test this works? If so, I'll review and merge.

@Tzrlk
Copy link

Tzrlk commented Aug 5, 2018

Just tested this and the issue appears to be fixed.

EDIT: Spoke too soon. After switching from 1.4.4-SNAPSHOT to 1.4.3 is continued to work, but failed when I went to 1.4.2. I then went back to 1.4.3, where it now failed, and then back to 1.4.4-SNAPSHOT where it continued to fail. I'll see if I can find out why it's giving me a BAD_CREDENTIAL error and report back.

EDIT 2: Turns out I just locked-out the account :P. Decryption works in 1.4.3 and 1.4.4-SNAPSHOT.

@jackson-chris
Copy link

Just tested these changes and they do address the problem I outlined in #204

@davidxia davidxia merged commit 1e2a128 into spotify:master Aug 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants